Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh)!: remove dialer::Dialer #3022

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

dignifiedquire
Copy link
Contributor

Description

Too specific of an API, the uses have been inlined in

Breaking Changes

  • removed iroh::dialer::Dialer and iroh::dialer

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@dignifiedquire dignifiedquire requested a review from flub December 9, 2024 16:30
Copy link

github-actions bot commented Dec 9, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3022/docs/iroh/

Last updated: 2024-12-10T11:22:44Z

Copy link

github-actions bot commented Dec 9, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 6e65eb7

@dignifiedquire dignifiedquire added this to the v0.30.0 milestone Dec 9, 2024
@dignifiedquire dignifiedquire added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 6a62c80 Dec 10, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants