Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh): Rename the relay-is-ready-to-send waker #3014

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Dec 5, 2024

Description

I thought I was going to put in a queue or channel of some sort... but
not yet. Still, let's rename this for now.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

I thought I was going to put in a queue or channel of some sort... but
not yet.  Still, let's rename this for now.
@flub flub requested a review from a team December 5, 2024 11:12
@flub flub enabled auto-merge December 5, 2024 11:13
Copy link

github-actions bot commented Dec 5, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3014/docs/iroh/

Last updated: 2024-12-05T11:15:32Z

Copy link

github-actions bot commented Dec 5, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: cde8fa8

@flub flub added this pull request to the merge queue Dec 5, 2024
Copy link
Contributor

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on replacing this with Arc<AtomicWaker>?
It'd be (almost) identical in functionality.

@matheus23
Copy link
Contributor

Lol @ the automerge. Oh well then

Merged via the queue into main with commit 79bf3c3 Dec 5, 2024
26 checks passed
@matheus23 matheus23 deleted the flub/rename-relay-waker branch December 5, 2024 12:31
@flub
Copy link
Contributor Author

flub commented Dec 5, 2024

Lol @ the automerge. Oh well then

Yeah sorry, was a good suggestion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants