refactor(iroh-relay)!: Always allow acking pings #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Client has a feature that stops it from sending pongs, it is unused and I'm not sure when you'd need that functionality. Remove it.
This is the problem with everything being pub. I still don't like pub.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3011/docs/iroh/ Last updated: 2024-12-05T09:29:46Z |
flub
changed the title
Arqu
approved these changes
Dec 5, 2024
dignifiedquire
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Client has a feature that stops it from sending pongs, it is
unused and I'm not sure when you'd need that functionality. Remove it.
Breaking Changes
iroh-relay
ClientBuilder::can_ack_pingsis removed, sending pong messages isalways allowed.
Notes & open questions
Change checklist