chore: prune some deps #2932
chore: prune some deps #2932
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2932/docs/iroh/ Last updated: 2024-11-27T10:56:53Z |
Arqu
force-pushed
the
arqu/deps_war
branch
2 times, most recently
from
b82dc84 to
29c456c
Compare
Arqu
force-pushed
the
arqu/deps_war
branch
4 times, most recently
from
314d4b0 to
f5b4b44
Compare
Cargo.toml
Outdated
| @@ -55,3 +55,5 @@ iroh-net = { path = "./iroh-net" } | |||
| iroh-metrics = { path = "./iroh-metrics" } | |||
| iroh-test = { path = "./iroh-test" } | |||
| iroh-router = { path = "./iroh-router" } | |||
|
|
|||
| tokio-rustls-acme = { git = "https://github.com/n0-computer/tokio-rustls-acme", branch = "main" } | |||
There was a problem hiding this comment.
Need a release for this.
iroh-dns-server/Cargo.toml
Outdated
| futures-lite = "2.3.0" | ||
| governor = "0.6.3" | ||
| futures-lite = "2.5" | ||
| governor = "0.6.0" #needs new release of tower_governor for 0.7.0 |
There was a problem hiding this comment.
I don't have any strong mechanic to follow this on an ongoing basis. Any ideas, otherwise it's just a manual purge / update every now and then.
| futures-lite = "2.3.0" | ||
| governor = "0.6.3" | ||
| futures-lite = "2.5" | ||
| governor = "0.6.3" #needs new release of tower_governor for 0.7.0 |
There was a problem hiding this comment.
I don't have any great way of doing this automatically or regularly. Im open to suggestions here on how to keep track of these other than to just manually revisit every so often and do this whole dance.
| netlink-sys = "0.8.6" | ||
| rtnetlink = "=0.14.1" # pinned because of https://github.com/rust-netlink/rtnetlink/issues/83 | ||
|
|
||
| [target.'cfg(target_os = "android")'.dependencies] |
There was a problem hiding this comment.
This is the ugly bit for android but is necessary right now unless we want to keep linux down to the same version it was because of android.
There was a problem hiding this comment.
Also need a way to track this too.
| if let Some(dst) = get_nla!(msg, route::RouteAttribute::Destination) { | ||
| match dst { | ||
| route::RouteAddress::Inet(addr) => { | ||
| if (table == 255 || table == 254) |
There was a problem hiding this comment.
I think I did this right but would like some extra 👀 on it @dignifiedquire
| @@ -100,16 +100,19 @@ impl CallbackHandler { | |||
| let mut handle = Handle::default(); | |||
| let cb = Arc::new(cb); | |||
| unsafe { | |||
| windows::Win32::NetworkManagement::IpHelper::NotifyUnicastIpAddressChange( | |||
| let r = windows::Win32::NetworkManagement::IpHelper::NotifyUnicastIpAddressChange( | |||
There was a problem hiding this comment.
This is stupid but we can no longer just ? the error we have to parse it manually.
| @@ -119,9 +122,12 @@ impl CallbackHandler { | |||
| handle: UnicastCallbackHandle, | |||
| ) -> Result<()> { | |||
| trace!("unregistering unicast callback"); | |||
| if self.unicast_callbacks.remove(&handle.0 .0).is_some() { | |||
| if self.unicast_callbacks.remove(&(handle.0 .0 as isize)).is_some() { | |||
There was a problem hiding this comment.
I did a lot of casting here to get things to align and tests pass, but this is scary and I'm not a 100% confident in these.
There was a problem hiding this comment.
it's fine, honestly I just use as _ in this case, as these numbers depend on the lib giving you the right type anyway
|
looks good for the most part |
Given CI passes this should now cover it. Our minimum version is from https://github.com/n0-computer/quinn/blob/iroh-0.11.x/Cargo.toml#L46C1-L46C52 We should probably free that up too on next release. |
Description
Getting started on cleaning up our deps tree as much as possible.
Closes #2883
This will continue to be an ongoing thing. We have a couple deps that are pending on releases from further deps. We've managed to clear out most of our own repos and iroh dependencies.
Breaking Changes
Notes & open questions
Change checklist