-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iroh-net): Switch to new iroh-relay route /relay
instead of /derp
#2489
Conversation
… `/derp` route to `/relay` But still keep accepting connections over `/derp` for backwards compatibility.
Base branch didn't switch automatically in the original PR... Will need to address conflicts today ✌️ |
This PR contains the same +5 -12 lines of code change that #2441 does (I verified this manually). |
one issue with this I see is that relays that are not updated will not work anymore, so we might want to wait even one more release to merge this |
@dignifiedquire one release more seems somewhat arbitrary. |
K. Talked with dig. it's a social problem: We need enough time to make sure we've told everyone who runs their own relay to update their relays before they update their code. That's all. |
@dignifiedquire looks like you've solved the social problem, given this is now assigned the 0.21 milestone. |
Split out from #2419, copy of #2441, because I forgot to switch the base branch 🙃
Splitting this out means we can deploy the relay changes one release in advance to the changes in the client.
Otherwise, we'd need to update the relays ASAP when we release 0.20, as clients will expect to be able to connect to the
/relay
route (which may not be deployed immediately after the release).Description
/relay
instead of/derp
.Breaking Changes
None
Notes & open questions
Also a PR related to #2378
I allowed myself to add in another
derive_more::Debug
instance instead of a custom, outdatedimpl Debug
, if that's okay with you 😁Change checklist