debug/fix: internal rpc cancel safety #2407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
reviewed
Jun 25, 2024
| // We cannot poll this in the tokio::select! because on completion a | ||
| // internal_rpc.accept() future could be dropped. But we need to clear | ||
| // finished tasks from the join_set to not amass them. | ||
| if let Some(Err(err)) = join_set.try_join_next() { |
There was a problem hiding this comment.
Wouldn't this have to be a loop? We pass the join_set into spawn_rpc_request so we don't really know how many tasks there are per request.
There was a problem hiding this comment.
this is just done so we clean them up eventually, current impl is also guranteed to be 1-1 but we can make that more explicit
|
This actually fixes things, but I think we can close it in favour of #2416 |
|
Yes, let's close it. Glad not having to do this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maybe flume is not cancel safe? If so, this might help to fix #2399
Breaking Changes
Notes & open questions
Change checklist