Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iroh): do not panic on blobs IO error #2400

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

Frando
Copy link
Member

@Frando Frando commented Jun 24, 2024

Description

  • We unwraped an io::Result in the RPC handler for BlobsReadAtRequest. Changed to return an error instead.
  • In the blobs client, report the error cases that can occur for reading a blob differently, to help debugging.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Frando Frando marked this pull request as ready for review June 24, 2024 10:03
@Frando Frando added this pull request to the merge queue Jun 24, 2024
@Frando Frando changed the title fix: do not panic on blobs db IO error fix(iroh): do not panic on blobs db IO error Jun 24, 2024
@Frando Frando changed the title fix(iroh): do not panic on blobs db IO error fix(iroh): do not panic on blobs IO error Jun 24, 2024
Merged via the queue into main with commit 38e8ce0 Jun 24, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants