feat(iroh)!: expand ability to connect to RPC #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
reviewed
Jun 24, 2024
| @@ -256,7 +260,11 @@ where | |||
| } | |||
|
|
|||
| /// Configure rpc endpoint, changing the type of the builder to the new endpoint type. | |||
| pub fn rpc_endpoint<E2: ServiceEndpoint<RpcService>>(self, value: E2) -> Builder<D, E2> { | |||
| pub fn rpc_endpoint<E2: ServiceEndpoint<RpcService>>( | |||
There was a problem hiding this comment.
Not for this PR probably, but I guess we don't need this whole type parameter anymore on the builder due to having the ability to box the endpoint.
So far we don't make use of this on the node side but just on the client side, but maybe something to do for the next release...
We need to get rid of type parameters to make room for new type parameters... 😁
rklaehn
reviewed
Jun 24, 2024
rklaehn
approved these changes
Jun 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Allows for easier connectivity of RPC, when not having access to the folder, e.g. in a docker setup ## Breaking Changes - renamed `iroh::client::Iroh::connect` -> `iroh::client::Iroh::connect_path` - added `iroh::client::Iroh::connect_addr` - added `rpc_port` field to `iroh::client::NodeStatus` ## Notes & open questions There might be nicer ways, but this works for now ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for easier connectivity of RPC, when not having access to the folder, e.g. in a docker setup
Breaking Changes
iroh::client::Iroh::connect->iroh::client::Iroh::connect_pathiroh::client::Iroh::connect_addrrpc_portfield toiroh::client::NodeStatusNotes & open questions
There might be nicer ways, but this works for now
Change checklist