Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(iroh-net): Remove a flaky test #2379

Merged
merged 2 commits into from
Jun 18, 2024
Merged

tests(iroh-net): Remove a flaky test #2379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e7704
tests(iroh-net): Remove a flaky test
flub Jun 18, 2024
818d706
tests(iroh): disable flaky test_default_author_presist
flub Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions iroh-net/src/dns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,17 +387,6 @@ pub(crate) mod tests {
const TIMEOUT: Duration = Duration::from_secs(5);
const STAGGERING_DELAYS: &[u64] = &[200, 300];

#[tokio::test]
#[cfg_attr(target_os = "windows", ignore = "flaky")]
async fn test_dns_lookup_basic() {
let _logging = iroh_test::logging::setup();
let resolver = default_resolver();
let res = resolver.lookup_ip(NA_RELAY_HOSTNAME).await.unwrap();
let res: Vec<_> = res.iter().collect();
assert!(!res.is_empty());
dbg!(res);
}

#[tokio::test]
async fn test_dns_lookup_ipv4_ipv6() {
let _logging = iroh_test::logging::setup();
Expand Down
1 change: 1 addition & 0 deletions iroh/src/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@ mod tests {
}

#[cfg(feature = "fs-store")]
#[ignore = "flaky"]
#[tokio::test]
async fn test_default_author_persist() -> Result<()> {
use crate::util::path::IrohPaths;
Expand Down
Loading