-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroh-gossip): configure the max message size #2340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe add some comments about a couple of caveats.
For example:
- This should be a network-wide configuration parameter to ensure all nodes can transmit and read large messages.
- This should be large enough to allow for gossip control messages to be sent.
- Any other we can think of
Frando
approved these changes
Jun 4, 2024
ramfox
force-pushed
the
feat/configure_max_message_size
branch
from
June 4, 2024 23:28
ca4fc44
to
132dfd0
Compare
ramfox
force-pushed
the
feat/configure_max_message_size
branch
from
June 5, 2024 17:29
127ae15
to
da59b54
Compare
ramfox
force-pushed
the
feat/configure_max_message_size
branch
from
June 5, 2024 17:56
da59b54
to
4f83ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add configuration option for
max_message_size
foriroh-gossip::proto::Config
.This
Config
gets used iniroh-gossip::Gossip::from_endpoint
.iroh-docs
still uses the default 4096 bytes. Themax_message_size
configuration is useful for folks usingiroh-gossip::Gossip
as its own library.closes #2312
Breaking Changes
Adds:
iroh-gossip::Gossip::max_message_size
- that reports the configured maximum message size for the gossip actor.Changes:
iroh_gossip::net::util::read_message
now takes amax_message_size: usize
parameteriroh_gossip::net::util::write_message
now takes amax_message_size: usize
parameteriroh_gossip::net::util::read_lp
now takes amax_message_size: usize
parameterRemoves:
iroh-gossip::proto:: MAX_MESSAGE_SIZE
constChange checklist