fix(iroh-net): fix extra delay #2330
Conversation
|
@flub I have fixed formatting issues. Could you please help to approve the CI workflow again? Thank you very much! |
iroh-net/src/magicsock.rs
Outdated
| let LocalAddresses { | ||
| regular: mut ips, | ||
| loopback, | ||
| } = LocalAddresses::new(); |
There was a problem hiding this comment.
This can still block the executor this is being spawned on. Could you wrap the new() call into tokio::task::spawn_blocking()? And also leave a comment that on windows this introduces a 10-20ms of delay so that we know why.
There was a problem hiding this comment.
I have made the modifications as per your suggestion and conducted some tests on the execution time of the latest version of the netdev::get_interfaces() function. conducting 30 tests for each scenario. The results are as follows:
windows（Lan + wifi off）：min: 9ms, max: 28ms
windows（Lan + wifi connects to mobile hotspot ）：min: 24ms, max: 1174ms
macos (Hackintosh X86): min: 1ms, max: 6ms
linux (7840hs + lan): min: 100us, max: 502us
linux (7840hs + 1lan connect + 3lan disconnect): min: 100us, max: 1092us
linux (2core cpu server + lan): min: 100us, max: 960us
The time taken for the function call may be influenced by the platform, the number of network interfaces, and CPU performance (such as on embedded devices or server). Therefore, in the comments, I did not limit my annotations to just Windows. The test results show that the Windows platform indeed takes the most time. Analyzing the source code of netdev for the Windows platform confirms that the outcome aligns with expectations.
There was a problem hiding this comment.
Thanks for these detailed numbers, it's great to see these written down!
|
See #2332 for the flaky test this found :( |
Co-authored-by: Floris Bruynooghe <[email protected]>
Thank you for your patient guidance. |
Thanks for your contributions! Finding and fixing where those delays are from is great! |
## Description Fix for #2328: Enumerating network devices is slow on windows and causes delays in the magicsock actor. This makes sure that this operation does not block the remainder of the actor. Also bumps netdev to v0.27.0 , to fix #2327. --------- Co-authored-by: Floris Bruynooghe <[email protected]>
Description
Fix for #2328: Enumerating network devices is slow
on windows and causes delays in the magicsock actor. This makes sure that this operation
does not block the remainder of the actor.
Also bumps netdev to v0.27.0 , to fix #2327.