Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store console files in subdirectory of iroh data dir #2300

Merged
merged 1 commit into from
May 23, 2024

Conversation

Frando
Copy link
Member

@Frando Frando commented May 15, 2024

Description

We used to store the console files (history and current author) in a subdirectory console under the iroh data dir. This got lost in some refacorings, and the console files currently are created in the iroh data directory directly.

This is bad because the iroh data directory is a single namespace, and we should use it cautiously.

This PR goes back to using a console subdirectory. Existing files are migrated on first start of the console.

Based on #2299 because this already made the environment init functions async.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Frando Frando changed the base branch from main to feat/default-author May 15, 2024 23:29
@Frando Frando force-pushed the fix-console-dirs branch 5 times, most recently from 2cf6484 to 84efbd1 Compare May 16, 2024 10:13
@Frando Frando force-pushed the feat/default-author branch 2 times, most recently from bf6a6ae to 8e5c238 Compare May 21, 2024 09:03
@dignifiedquire
Copy link
Contributor

@Frando meeeerge conflicts

@Frando Frando force-pushed the fix-console-dirs branch from 84efbd1 to 4c66cdf Compare May 23, 2024 00:00
@Frando Frando force-pushed the feat/default-author branch from 7fbaccf to 62423aa Compare May 23, 2024 00:00
@Frando
Copy link
Member Author

Frando commented May 23, 2024

@dignifiedquire rebased

@dignifiedquire dignifiedquire merged commit 0b8188c into feat/default-author May 23, 2024
@dignifiedquire dignifiedquire deleted the fix-console-dirs branch May 23, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants