Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(willow): use single-threaded tokio runtime instead of manual coroutines #2293

Merged
merged 6 commits into from
May 15, 2024
Merged

refactor(willow): use single-threaded tokio runtime instead of manual coroutines #2293

merged 6 commits into from
May 15, 2024

Conversation

Frando
Copy link
Member

@Frando Frando commented May 15, 2024 •
edited
Loading

Description

Refactors and improvments to #2231 :

  • Use a single-threaded tokio runtime in the actor loop (instead of manual genawaiter coroutines)
  • Use separate channels as in the spec and process them concurrently
  • Hide RefCells as much as possible to prevent deadlocks
  • Improve code flow around opening channels in net module

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Frando Frando changed the base branch from main to willow May 15, 2024 10:05
@Frando Frando merged commit 797ff2b into willow May 15, 2024
4 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Frando