feat(iroh-net): small improvements to dns behaviour #2290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
flub
reviewed
May 14, 2024
Comment on lines
+70
to
+71
| // ensure multiple name servers are queried concurrently | ||
| options.num_concurrent_reqs = 3; |
There was a problem hiding this comment.
Sorry, only just realised this comment. It queries multiple DNS servers concurrently, but we typically only have a single DNS server. We want (I think) to be robust in case the UDP packet to this server is lost and thus do multiple concurrent requests to the same server, but with staggered starts so that you don't always pay the price of the multiple requests if your DNS server is fast enough.
|
Maybe this PR could also attempt removing the flaky label of the windows DNS tests? See #2086 |
|
Closing this to tackle it in a fresh one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2277
timeout. However, from a quick check of hickory's docs, the default is a
number of concurrent requests of 2. In summary, this was never actually an
issue. To ensure we keep this behaviour even if the default changes, set the
number of concurrent requests to 3.. just to gives us more room.
actually avoid it.
Breaking Changes
n/a
Notes & open questions
From reading hickory's code and adding there some dirty log statements, this is
(and was) working as intended.
Change checklist
Tests if relevant.All breaking changes documented.