Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iroh-net)!: Rename MagicEndpoint -> Endpoint #2287

Merged
merged 4 commits into from
May 13, 2024
Merged

refactor(iroh-net)!: Rename MagicEndpoint -> Endpoint #2287

merged 4 commits into from
May 13, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented May 13, 2024 •
edited
Loading

Description

This renames the MagicEndpoint (and it's builder) into Endpoint.
Hopefully providing a more consistent API.

Breaking Changes

  • iroh_net::magic_endpoint -> iroh_net::endpoint
  • iroh_net::magic_endpoint::MagicEndpoint -> iroh_net::endpoint::Endpoint
  • iroh_net::magic_endpoint::MagicEndpointBuilder -> iroh_net::endpoint::Builder
  • iroh::node::Node::magic_endpoint -> iroh::node::Node::endpoint

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@flub
refactor(iroh-net)!: Rename MagicEndpoint -> Endpoint
5ae479a 
This renames the MagicEndpoint (and it's builder) into Endpoint.
Hopefully providing a more consistent API.
@flub flub force-pushed the flub/endpoint-no-magic branch from 4ecd732 to 5ae479a Compare May 13, 2024 15:30
@divagant-martian divagant-martian added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit f4d6ca1 May 13, 2024
21 of 22 checks passed
@divagant-martian divagant-martian deleted the flub/endpoint-no-magic branch May 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divagant-martian divagant-martian divagant-martian approved these changes

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flub @dignifiedquire @divagant-martian