refactor(iroh-net)!: Make the interfaces module private #2266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is leaking 3rd party types into our public interface, since this
really only exists for our own use it probably shouldn't be public to
start with. So make it private. As a result cleans up some dead
code.
Breaking Changes
The
iroh_net::net::interfaces
module has been made private.Notes & open questions
There is probably more in
iroh_net::net
that needs to be private.Maybe even the whole module. I'm not sure if doing this stepwise or
in one large chunk is better. This takes the stepwise approach.
Change checklist