Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iroh-net)!: Make the interfaces module private #2266

Merged
merged 2 commits into from
May 6, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented May 6, 2024

Description

This is leaking 3rd party types into our public interface, since this
really only exists for our own use it probably shouldn't be public to
start with. So make it private. As a result cleans up some dead
code.

Breaking Changes

The iroh_net::net::interfaces module has been made private.

Notes & open questions

There is probably more in iroh_net::net that needs to be private.
Maybe even the whole module. I'm not sure if doing this stepwise or
in one large chunk is better. This takes the stepwise approach.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.
  • All breaking changes documented.

This is leaking 3rd party types into our public interface, since this
really only exists for our own use it probably shouldn't be public to
start with.  So make it private.  As a result cleans up some dead
code.
@flub flub enabled auto-merge May 6, 2024 09:25
@flub flub disabled auto-merge May 6, 2024 12:55
@flub flub enabled auto-merge May 6, 2024 12:56
@flub flub added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 38bdaef May 6, 2024
20 of 21 checks passed
@flub flub deleted the flub/private-interfaces branch May 6, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants