feat(iroh-cli): Make ticket-inspect print full node ids #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add the option to show them in zbase32 format for pkarr interop
dignifiedquire
approved these changes
May 2, 2024
|
nitpick:
|
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description
feat(iroh-cli): Make ticket-inspect print full node ids
also add the option to show them in zbase32 format for pkarr interop. I
need this in the workshop.
Before:
```
Blob ticket:
BlobTicket {
node: NodeAddr {
node_id: PublicKey(sq46x6htizk6222l),
info: AddrInfo {
relay_url: Some(
RelayUrl(
"https://euw1-1.relay.iroh.network./",
),
),
direct_addresses: {
82.76.245.75:50824,
192.168.1.131:50824,
192.168.1.149:50824,
},
},
},
format: HashSeq,
hash: Hash(
cc4c9cd6bee4e1730447264b8290d83b3f901d88152ff0ecefb5e3050d0c500f,
),
}
```
After:
```
BlobTicket
hash: zrgjzvv64tqxgbchezfyfegyhm7zahmicux7b3hpwxrqkdimkahq
format: HashSeq
Node Info
node-id: sq46x6htizk6222lyz7jc4ofe3tymyw27joi3jzuhskavjczmcya
relay-url: https://euw1-1.relay.iroh.network./
addr: 82.76.245.75:50824
addr: 192.168.1.131:50824
addr: 192.168.1.149:50824
```
## Breaking Changes
None
## Notes & open questions
None
## Change checklist
- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(iroh-cli): Make ticket-inspect print full node ids
also add the option to show them in zbase32 format for pkarr interop. I need this in the workshop.
Before:
After:
Breaking Changes
None
Notes & open questions
None
Change checklist