feat(doctor): Report connection type changes in rolling fashion #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doctor already shows the current connection type, this changes to show changes in a rolling fashion. This is not exact and some switches might be missed since the doctor mechanism this hooks into is poll based. A better version would be using the new conn_type_stream and print each change.
dignifiedquire
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The doctor already shows the current connection type, this changes to show changes in a rolling fashion.
It also unambiguously logs each connection type change now.
This now prints something like:
Connection with gzjlsppiplwpp7pn changed: direct (after 1.548µs)on each connection change.
Breaking Changes
Notes & open questions
Despite using the conn_type_stream this stream events are still lost, especially very early on in the connection lifetime.
Change checklist