Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(iroh-blake3): Upgrade to version fixing more symbol collions #2246

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Apr 26, 2024

Description

We did get reports of the iroh-blake3 still having symbol collisions
with blake3. Depend on the new version now. Hopefully these were the
last of the symbol collisions.

Closes #2217

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • [ ] Documentation updates if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

We did get reports of the iroh-blake3 still having symbol collisions
with blake3.  Depend on the new version now.  Hopefully these were the
last of the symbol collisions.

Closes #2217
@flub flub enabled auto-merge April 26, 2024 12:51
@flub flub added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 0c336c4 Apr 26, 2024
21 checks passed
@flub flub deleted the flub/iroh-blake3-neon-symbols branch October 4, 2024 08:49
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
)

## Description

We did get reports of the iroh-blake3 still having symbol collisions
with blake3.  Depend on the new version now.  Hopefully these were the
last of the symbol collisions.

Closes #2217

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- ~~[ ] Documentation updates if relevant.~~
- ~~[ ] Tests if relevant.~~
- ~~[ ] All breaking changes documented.~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Symbol collisions when building with both iroh and ssi crates as dependencies
2 participants