fix(ci): release builds #2219
Merged
fix(ci): release builds #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
force-pushed
the
arqu/release_windows
branch
from
0112eb4 to
77e5a4e
Compare
dignifiedquire
approved these changes
Apr 29, 2024
flub
approved these changes
Apr 29, 2024
| @@ -30,6 +30,7 @@ env: | |||
| MSRV: "1.75" | |||
| SCCACHE_CACHE_SIZE: "50G" | |||
| BIN_NAMES: "iroh,iroh-relay,iroh-dns-server" | |||
| RELEASE_VERSION: ${{ github.event.inputs.release_version }} | |||
There was a problem hiding this comment.
Given you have a whole script a little lower to set this in several ways I assume this is a leftover of an earlier version and should be removed?
Comment on lines
+156
to
+159
|
|
||
| - name: build release | ||
| if: matrix.os == 'windows-latest' | ||
| run: cargo build --profile optimized-release --all-features --target ${{ matrix.cargo_targets }} |
There was a problem hiding this comment.
I don't get why windows gets its own section here, the cargo command is exactly the same as the unix version above?
| Add-Content -Path $env:GITHUB_ENV -Value "ASSET=$ASSETS" | ||
|
|
||
| - uses: n0-computer/actions-upload-release-asset@main |
There was a problem hiding this comment.
I'm in general a bit careful about using actions from a branch rather than a tag, which can still be moving like .e.g. v1. But the repo doesn't seem to have any tags.
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description Runs the usual release flow, but now also creates a draft release and attaches all binaries to it. Also closes: #2232 Sample: https://github.com/n0-computer/iroh/releases/tag/untagged-b36c22bc1e19cbd75396 ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Runs the usual release flow, but now also creates a draft release and attaches all binaries to it.
Also closes: #2232
Sample: https://github.com/n0-computer/iroh/releases/tag/untagged-b36c22bc1e19cbd75396
Breaking Changes
Notes & open questions
Change checklist