Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve breaking change handling #2207

Merged
merged 24 commits into from
Apr 18, 2024
Merged

docs: improve breaking change handling #2207

merged 24 commits into from
Apr 18, 2024

Conversation

dignifiedquire
Copy link
Contributor

  • update issue template
  • update CONTRIBUTING.md
  • add semver checker to CI

@@ -12,3 +12,5 @@ jobs:
- name: check-for-cc
id: check-for-cc
uses: agenthunt/[email protected]
with:
pr-title-regex: "^(.+)(?:(([^)s]+)))?!?: (.+)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this changing from the defaults?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it adds the ability to add the ! as I described in the CONTRIBUTING.md to mark breaking changes

@divagant-martian divagant-martian added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit d55b782 Apr 18, 2024
21 checks passed
@dignifiedquire dignifiedquire deleted the feat-breaking branch April 18, 2024 16:15
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
- update issue template
- update `CONTRIBUTING.md`
- add semver checker to CI

---------

Co-authored-by: Asmir Avdicevic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants