feat: iroh-perf #2186
Merged
feat: iroh-perf #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iroh-net/bench/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "iroh-net-bench" | |||
| version = "0.16.0" | |||
| version = "0.13.0" | |||
dignifiedquire
approved these changes
May 22, 2024
flub
approved these changes
May 22, 2024
iroh-net/bench/src/quinn.rs
Outdated
Comment on lines
89
to
90
| .context("connecting") | ||
| .unwrap(); |
There was a problem hiding this comment.
This won't do anything, you probably want .expect("connecting") instead.
iroh-net/bench/src/lib.rs
Outdated
Comment on lines
225
to
226
| stats.upload_stats.total_duration = start.elapsed(); | ||
| stats.download_stats.total_duration = start.elapsed(); |
There was a problem hiding this comment.
maybe move this up to right after acquire_many()? Probably not a big difference though
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description
In progress thing for what should later be `iroh-perf`. For now you can
run with `cargo run --release -- iroh` and `cargo run --release --
quinn` to do a simple comparison benchmark.
More knobs are available for tuning with `--help`.
There's a much more stark difference on macOS compared to running on
Linux.
Next steps bumping to test against `quinn 0.11`
Sample output:
```
iroh (macOS)
Client 0 stats:
Connect time: 13.788583ms
Overall download stats:
Transferred 1073741824 bytes on 1 streams in 5.47s (187.27 MiB/s)
Time to first byte (TTFB): 1ms
Total chunks: 130319
Average chunk time: 41.936ms
Average chunk size: 8.04KiB
Stream download metrics:
│ Throughput │ Duration
──────┼───────────────┼──────────
AVG │ 187.31 MiB/s │ 5.47s
P0 │ 187.25 MiB/s │ 5.46s
P10 │ 187.37 MiB/s │ 5.47s
P50 │ 187.37 MiB/s │ 5.47s
P90 │ 187.37 MiB/s │ 5.47s
P100 │ 187.37 MiB/s │ 5.47s
```
```
quinn (macOS)
Client 0 stats:
Connect time: 1.81875ms
Overall download stats:
Transferred 1073741824 bytes on 1 streams in 2.85s (358.92 MiB/s)
Time to first byte (TTFB): 61.168ms
Total chunks: 47412
Average chunk time: 60.176ms
Average chunk size: 22.12KiB
Stream download metrics:
│ Throughput │ Duration
──────┼───────────────┼──────────
AVG │ 358.88 MiB/s │ 2.85s
P0 │ 358.75 MiB/s │ 2.85s
P10 │ 359.00 MiB/s │ 2.85s
P50 │ 359.00 MiB/s │ 2.85s
P90 │ 359.00 MiB/s │ 2.85s
P100 │ 359.00 MiB/s │ 2.85s
```
```
iroh (linux)
Client 0 stats:
Connect time: 3.83554ms
Overall download stats:
Transferred 1073741824 bytes on 1 streams in 1.16s (884.52 MiB/s)
Time to first byte (TTFB): 2.014ms
Total chunks: 38046
Average chunk time: 30.408ms
Average chunk size: 27.55KiB
Stream download metrics:
│ Throughput │ Duration
──────┼───────────────┼──────────
AVG │ 884.75 MiB/s │ 1.16s
P0 │ 884.50 MiB/s │ 1.16s
P10 │ 885.00 MiB/s │ 1.16s
P50 │ 885.00 MiB/s │ 1.16s
P90 │ 885.00 MiB/s │ 1.16s
P100 │ 885.00 MiB/s │ 1.16s
```
```
quinn (linux)
Client 0 stats:
Connect time: 1.22085ms
Overall download stats:
Transferred 1073741824 bytes on 1 streams in 994.57ms (1029.59 MiB/s)
Time to first byte (TTFB): 1.483ms
Total chunks: 32809
Average chunk time: 30.296ms
Average chunk size: 31.96KiB
Stream download metrics:
│ Throughput │ Duration
──────┼───────────────┼──────────
AVG │ 1030.50 MiB/s │ 993.00ms
P0 │ 1030.00 MiB/s │ 993.00ms
P10 │ 1031.00 MiB/s │ 993.00ms
P50 │ 1031.00 MiB/s │ 993.00ms
P90 │ 1031.00 MiB/s │ 993.00ms
P100 │ 1031.00 MiB/s │ 993.00ms
```
## Notes & open questions
<!-- Any notes, remarks or open questions you have to make about the PR.
-->
## Change checklist
- [ ] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In progress thing for what should later be
iroh-perf. For now you can run withcargo run --release -- irohandcargo run --release -- quinnto do a simple comparison benchmark.More knobs are available for tuning with
--help.There's a much more stark difference on macOS compared to running on Linux.
Next steps bumping to test against
quinn 0.11Sample output:
Notes & open questions
Change checklist