feat: retry nodes in downloader #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
feat/downloader-retry
branch
6 times, most recently
from
dee77b0 to
6e2b25d
Compare
3 tasks
Frando
force-pushed
the
feat/downloader-retry
branch
2 times, most recently
from
16dfd92 to
a26222a
Compare
Frando
force-pushed
the
feat/downloader-retry
branch
from
084ab39 to
aa7b333
Compare
Frando
force-pushed
the
feat/downloader-retry
branch
from
aa7b333 to
bbd0155
Compare
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 18, 2024
## Description adds retries to the downloader: * after a node fails to dial, or fails during a transfer with IO errors, we move the node into a delay queue, with an increasing timeout. once the delay expires, the node may be dialed again. * if the head of the download queue can only proceed with nodes which are currently in the retry queue, we *park* the download in a separate set from the main queue, and proceed with the next download * once a retrying node succeeds to reconnect, we unpark all parked hashes for which this node is a candidate
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Apr 21, 2024
## Description adds retries to the downloader: * after a node fails to dial, or fails during a transfer with IO errors, we move the node into a delay queue, with an increasing timeout. once the delay expires, the node may be dialed again. * if the head of the download queue can only proceed with nodes which are currently in the retry queue, we *park* the download in a separate set from the main queue, and proceed with the next download * once a retrying node succeeds to reconnect, we unpark all parked hashes for which this node is a candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds retries to #2085:
Notes & open questions
Has a smoke test for retry behavior. Adding more tests would be great.
Change checklist