Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Also test iroh-cli for cargo features #2122

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

flub
Copy link
Contributor

@flub flub commented Mar 25, 2024

Description

We really ought to use something like cargo-metadata to pull this
information from the cargo.toml file. Maybe one day one of us will be
motivated enough to do this.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

We really ought to use something like cargo-metadata to pull this
information from the cargo.toml file.  Maybe one day one of us will be
motivated enough to do this.
@flub flub changed the title fix(ci): Make sure all crates get tested for features fix(ci): Also test iroh-cli for cargo features Mar 25, 2024
@flub flub requested review from dignifiedquire and Arqu March 25, 2024 10:16
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@flub flub added this pull request to the merge queue Mar 25, 2024
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Merged via the queue into main with commit a136b1d Mar 25, 2024
20 checks passed
@flub flub deleted the flub/ci-features-all-crates branch March 25, 2024 11:04
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

We really ought to use something like cargo-metadata to pull this
information from the cargo.toml file.  Maybe one day one of us will be
motivated enough to do this.

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants