refactor(iroh-bytes): make module name and feature flags consistent with docs db #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e docs store Also rename the feature flag to be consistent.
dignifiedquire
approved these changes
Mar 21, 2024
# Conflicts: # iroh-cli/src/commands/start.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor(iroh-bytes): make module name and feature flags consistent with docs db
file::Store becomes fs::Store, and "file-db" feature becomes "fs-store" feature.
Notes & open questions
We could make it either way, I care more about consistency than about my naming choice. But if we do it let's do it fast so I don't have merge hell...
Change checklist