feat(iroh-net): Use the local endpoints info when closing derps #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the network has changed we used to close all the derp connections unconditionally. This passes in the local endpoints information so that the derp http actor will only close those derp connections for which we no longer have the local endpoint. That's a lot less disruptive than always closing them.
dignifiedquire
approved these changes
Mar 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
#2086 for flaky tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the network has changed we used to close all the derp connections
unconditionally. This passes in the local endpoints information so
that the derp http actor will only close those derp connections for
which we no longer have the local endpoint. That's a lot less
disruptive than always closing them.
Notes & open questions
The relevant rebinding test is still marked flaky. I've only seen it
pass but will monitor in the flaky tests before considering enabling.
Change checklist