feat(iroh): --exec option to run commands on iroh start
#1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Changes for #1802 CLI command changes: * `iroh start` takes `--add` not `--source` * `iroh blob add` takes required `SOURCE` arg and not optional `--source` opt Internal changes: * reduce code duplication around starting a node * always start the metrics server (for both `iroh start` and `iroh CMD --start`) * make sure to remove the rpc lock file if aborting with error * cleanups ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - ~~[ ] Tests if relevant.~~
## Description Some small refactors and code improvements on top of #1802
|
closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
--execor-eoption toiroh startto run any console command when starting a node withiroh start.The option can be passed multiple times.
This is e.g. a valid invocation:
Leaving at draft for now. This goes in the direction of a scripting language for iroh, which will warrant some further discussion likely.
Based on #1802
Notes & open questions
Change checklist