fix(iroh-net): reverse ip-port mapping stores only direct addresses in the peermap #1606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were storing reverse mappings for
SendAddr::Derp
in thePeerMap
. This means basically treating the DERP as a peer itself. We concluded this is something we shouldn't do. To fix the issue, the better solution is to enforce it via the type system. As such, we now only do reverse mapping from socket addresses.As a note, I added a new type
IpPort
. UsingSocketAddr
s as key to hashmaps often goes wrong with ipv6 because of the flow control & class fields it contains. These fields can't be assumed stable even within the same connection: sending a the socket address made from an (ipv6, port) and receiving a response can make it look like the socket address is different (same ip, same port, different flow labels) Ignoring these fields has some limitations in extremely exceptional cases (link local addresses with a single interface) As a note, ignoring these fields is what tailscale does (all they store is an ip and a port). This makes communications over ipv6 work better in the common case so I think it's worth doingNotes & open questions
Some references
Change checklist