tests(iroh-net): Remove a flaky test #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flakyness seems to have been successfully addressed by the staggered DNS lookup. Converting this test to that basically results in the same code as the next test: test_dns_lookup_ipv4_ipv6. So just remove this test as it no longer provides value.
dignifiedquire
approved these changes
Jun 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
oh the irony! |
ppodolsky
pushed a commit
to izihawa/iroh
that referenced
this pull request
Jun 22, 2024
## Description This flakyness seems to have been successfully addressed by the staggered DNS lookup. Converting this test to that basically results in the same code as the next test: test_dns_lookup_ipv4_ipv6. So just remove this test as it no longer provides value. ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions See n0-computer#2380 for the flaky test. ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates if relevant.~~ - [x] Tests if relevant. - ~~[ ] All breaking changes documented.~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This flakyness seems to have been successfully addressed by the
staggered DNS lookup. Converting this test to that basically results
in the same code as the next test: test_dns_lookup_ipv4_ipv6. So just
remove this test as it no longer provides value.
Breaking Changes
Notes & open questions
See #2380 for the flaky test.
Change checklist
[ ] Documentation updates if relevant.[ ] All breaking changes documented.