Move relay HTTP handler to be served on /relay #2378
Labels
Comments
Merged
4 tasks
|
We can start supporting both options and use |
|
Can you explain why we remove derp option we are facing problem today our peer can not connect because iroh server is shutting down |
Could you please open a new issue for your problem and describe exactly what happened and maybe provide logs to show how it looked as well? We're not removing anything in this issue, we are renaming things from "derp" to "relay" and the URL endpoint is one of the things we want to rename. |
This was referenced Jun 24, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 2, 2024
… `/derp` route to `/relay` (#2419) ## Description - Removes `relay_endpoint` config option from `ServerBuilder` - Makes `iroh-relay` accept both `/derp` and `/relay` as paths for relaying - Makes `/relay` the default path used in the iroh-net client TODO: - [x] Test both URLs ## Breaking Changes - `iroh_net::relay::http::ServerBuilder`: Removed `relay_endpoint` function ## Notes & open questions Closes #2378 ✅ Merge this after #2387 ## Change checklist - [X] Self-review. - [X] Documentation updates if relevant. - [X] Tests if relevant. - [X] All breaking changes documented.
matheus23
added a commit
that referenced
this issue
Jul 11, 2024
…f `/derp` (#2441) Split out from #2419 Splitting this out means we can deploy the relay changes one release in advance to the changes in the client. Otherwise, we'd need to update the relays ASAP when we release 0.20, as clients will expect to be able to connect to the `/relay` route (which may not be deployed immediately after the release). ## Description - Switches the client to connect to `/relay` instead of `/derp`. ## Breaking Changes None ## Notes & open questions Also a PR related to #2378 I allowed myself to add in another `derive_more::Debug` instance instead of a custom, outdated `impl Debug`, if that's okay with you 😁 ## Change checklist - [X] Self-review. - [X] Documentation updates if relevant. - [X] Tests if relevant. - [X] All breaking changes documented.
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 18, 2024
…f `/derp` (#2489) Split out from #2419, copy of #2441, because I forgot to switch the base branch 🙃 Splitting this out means we can deploy the relay changes one release in advance to the changes in the client. Otherwise, we'd need to update the relays ASAP when we release 0.20, as clients will expect to be able to connect to the `/relay` route (which may not be deployed immediately after the release). ## Description - Switches the client to connect to `/relay` instead of `/derp`. ## Breaking Changes None ## Notes & open questions Also a PR related to #2378 I allowed myself to add in another `derive_more::Debug` instance instead of a custom, outdated `impl Debug`, if that's okay with you 😁 ## Change checklist - [X] Self-review. - [X] Documentation updates if relevant. - [X] Tests if relevant. - [X] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the relay HTTP handler is served on
/derp. We should transition that to/relaybefore we stabilise the wire protocol. But we want to coordinate this as it is a breaking wire-level change.The text was updated successfully, but these errors were encountered: