fix: only call add_node_addr for non-empty node addrs

n0-computer · Jul 9, 2024 · fc6f99a · fc6f99a
1 parent 777fd73
commit fc6f99a
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/iroh-docs/src/engine/live.rs b/iroh-docs/src/engine/live.rs
@@ -452,12 +452,18 @@ impl<B: iroh_blobs::store::Store> LiveActor<B> {
         // add addresses of peers to our endpoint address book
         for peer in peers.into_iter() {
             let peer_id = peer.node_id;
-            match self.endpoint.add_node_addr_with_source(peer, SOURCE_NAME) {
-                Ok(()) => {
-                    peer_ids.push(peer_id);
-                }
-                Err(err) => {
-                    warn!(peer = %peer_id.fmt_short(), "failed to add known addrs: {err:?}");
+            // adding a node address without any addressing info fails with an error,
+            // but we still want to include those peers because node discovery might find addresses for them
+            if peer.info.is_empty() {
+                peer_ids.push(peer_id)
+            } else {
+                match self.endpoint.add_node_addr_with_source(peer, SOURCE_NAME) {
+                    Ok(()) => {
+                        peer_ids.push(peer_id);
+                    }
+                    Err(err) => {
+                        warn!(peer = %peer_id.fmt_short(), "failed to add known addrs: {err:?}");
+                    }
                 }
             }
         }