Skip to content

Commit

Permalink
chore(iroh-bytes): update bao-tree dependency (#2119)
Browse files Browse the repository at this point in the history
## Description

chore(iroh-bytes): update bao-tree dependency

to fix a bug with validation when the last chunk group is a leaf for the
tree. The bugfix was supposed to be in 0.11.0, but I screwed up
publishing.

Some indication that this fixes the problem:

main:
```
❯ cargo run -p iroh-cli doctor blob-validate $APP_HOME/iroh/blobs | grep expected
    Finished dev [unoptimized + debuginfo] target(s) in 0.18s
     Running `target/debug/iroh doctor blob-validate '/Users/rklaehn/Library/Application Support//iroh/blobs'`
EntryDone { id: 32, error: Some("expected chunk ranges RangeSet{0..1387}, got chunk ranges RangeSet{0..1376}") }
EntryDone { id: 9, error: Some("expected chunk ranges RangeSet{0..18856}, got chunk ranges RangeSet{0..18848}") }
```

this branch:
```
❯ cargo run -p iroh-cli doctor blob-validate $APP_HOME/iroh/blobs | grep expected
    Finished dev [unoptimized + debuginfo] target(s) in 0.18s
     Running `target/debug/iroh doctor blob-validate '/Users/rklaehn/Library/Application Support//iroh/blobs'`
```

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [ ] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.
  • Loading branch information
rklaehn authored Mar 23, 2024
1 parent 50b3e47 commit bed14d4
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion iroh-base/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ workspace = true

[dependencies]
anyhow = { version = "1" }
bao-tree = { version = "0.11", features = ["tokio_fsm", "validate"], default-features = false, optional = true }
bao-tree = { version = "0.11.1", features = ["tokio_fsm", "validate"], default-features = false, optional = true }
data-encoding = { version = "2.3.3", optional = true }
hex = "0.4.3"
multibase = { version = "0.9.1", optional = true }
Expand Down
2 changes: 1 addition & 1 deletion iroh-bytes/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ workspace = true

[dependencies]
anyhow = { version = "1" }
bao-tree = { version = "0.11", features = ["tokio_fsm"], default-features = false }
bao-tree = { version = "0.11.1", features = ["tokio_fsm"], default-features = false }
bytes = { version = "1.4", features = ["serde"] }
chrono = "0.4.31"
data-encoding = "2.3.3"
Expand Down
2 changes: 1 addition & 1 deletion iroh-cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ doc = false

[dependencies]
anyhow = "1.0.81"
bao-tree = { version = "0.11" }
bao-tree = { version = "0.11.1" }
bytes = "1.5.0"
clap = { version = "4", features = ["derive"] }
colored = { version = "2.0.4" }
Expand Down
2 changes: 1 addition & 1 deletion iroh/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ workspace = true

[dependencies]
anyhow = { version = "1" }
bao-tree = { version = "0.11", features = ["tokio_fsm"], default-features = false }
bao-tree = { version = "0.11.1", features = ["tokio_fsm"], default-features = false }
bytes = "1"
data-encoding = "2.4.0"
derive_more = { version = "1.0.0-beta.1", features = ["debug", "display", "from", "try_into", "from_str"] }
Expand Down

0 comments on commit bed14d4

Please sign in to comment.