Mark test as non-flaky, remove panicing test

n0-computer · Mar 13, 2024 · 8ff3e28 · 8ff3e28
1 parent b76a381
commit 8ff3e28
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/iroh-net/src/dns.rs b/iroh-net/src/dns.rs
@@ -45,7 +45,6 @@ fn get_resolver() -> Result<TokioAsyncResolver> {
             config.add_name_server(nameserver_cfg.clone());
         }
     }
-    dbg!(config.name_servers());
 
     // lookup IPv4 and IPv6 in parallel
     options.ip_strategy = hickory_resolver::config::LookupIpStrategy::Ipv4thenIpv6;
@@ -131,12 +130,6 @@ mod tests {
 
     use super::*;
 
-    #[test]
-    fn test_get_resolver() {
-        let _resolver = get_resolver();
-        panic!("boom");
-    }
-
     #[tokio::test]
     async fn test_dns_lookup_basic() {
         let res = DNS_RESOLVER.lookup_ip(NA_DERP_HOSTNAME).await.unwrap();

diff --git a/iroh-net/src/netcheck/reportgen.rs b/iroh-net/src/netcheck/reportgen.rs
@@ -1309,7 +1309,6 @@ mod tests {
     //
     // TODO: Not sure what about IPv6 pings using sysctl.
     #[tokio::test]
-    #[cfg_attr(target_os = "windows", ignore = "flaky")]
     async fn test_icmp_probe_eu_derper() {
         let _logging_guard = iroh_test::logging::setup();
         let pinger = Pinger::new();