Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Northumberland] Fetch extra_details from Alloy #358

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

@nephila-nacrea nephila-nacrea commented Aug 29, 2024

For https://mysocietysupport.freshdesk.com/a/tickets/3082 / https://github.com/mysociety/societyworks/issues/4507.

Config changes for staging and live also made in mysociety-servers/vhosts/open311-adapter/conf_council-northumberland_alloy.yml.ugly.

@nephila-nacrea nephila-nacrea self-assigned this Sep 3, 2024
@nephila-nacrea nephila-nacrea force-pushed the nland-assigned-to-extra-details branch 4 times, most recently from 8346eb9 to 727864f Compare September 4, 2024 23:58
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested refactor of a function that's similar to something existing is all, looks good :)

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@dracos dracos force-pushed the nland-assigned-to-extra-details branch from b86e9b6 to 305a485 Compare November 26, 2024 11:50
@dracos
Copy link
Member

dracos commented Nov 26, 2024

(Rebased/tweaked on top of my Alloy changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants