-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bunch of aesthetic and functional changes #524
base: main
Are you sure you want to change the base?
Conversation
have a look @mylinuxforwork |
@ElectroPerf Wow. So many great improvements. I will look into each one. Please understand that I can't merge everything at once into the main branch. |
@mylinuxforwork i completely understand that. Take your time man. Have a look at everything and go one by one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElectroPerf Just tested this prompt. Looks great. But I would love that the colors follow pywal. Do you know how to include one of the files in .cache/wal into the prompt config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean we can have it for now while we do that improvement later. I'm working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Changed it on my dev environment and I start testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElectroPerf I have integrated your rofi config into the latest commit to the main branch. Just made some minor changes for the colors. Thanks again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, also about the fastfetch png's color sync with pywal, it's a mess. I mean it generates images but have to clear fastfetch cache everytime so it views the new image which doesn't work all the time. And the png's quality degrades a lot because using magick to fill colors in. It's better to have the default png as it is for now @mylinuxforwork
EDIT: nevermind i fixed it but idk how to automate the script to run on every wallpaper change, i hope u can do it. lol
@mylinuxforwork now i think only fastfetch, network module change for showing wifi ssid and swaync is left to merge |
@mylinuxforwork this works perfectly, but the issue is idk how to make this script run everytime we change the wallpaper so it can regen the image for fastfetch, would be better if u could assist with it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ElectroPerf Added the the ssid name and icon for disconnected status to the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks
But this doesn't work on fedora, right? Because the Arch Logo is a linked image. |
@ElectroPerf Just updated the rofi css files. Made some adjustments and finetuning. You can change the border-radius in the file https://github.com/mylinuxforwork/dotfiles/blob/main/share/dotfiles/.config/ml4w/settings/rofi-border-radius.rasi |
It will work, why wouldn't it. There's nothing archlinux specific in it, well, u might try to introduce a fedora png like that i guess but other than that everything should work |
Great |
https://aur.archlinux.org/packages/oh-my-posh This has to do with the AUR package not installing. Change-Id: I5d45b04025011e951a12cf09a3e0af803489f797
The logo auto generates everytime based on the pywal color Change-Id: Ie0e20f2836ef6535890b87b38c1aed70790626b1
Change-Id: I56d89e3b7b9f23a8ba6b7f60069161c08bf50f4c
hey @mylinuxforwork this commit does change the logo as per the pywal colors and gets set everytime we open terminal |
and this fixes the aur problem where posh doesnt installl |
Like this enhancements. But I need a solution for Fedora users as well. And for the upcoming opensuse tumbleweed support. Any idea? |
@mylinuxforwork can u explain whats the issue with fedora, i will provide a fix. I am an archlinux user so idk much about fedora |
Hey, I see that the rofi change came from this pr, I understand some people might like it more, but I personally like the old style more, there should be a way to revert... |
he just means the arch image will also be shown on fedora, which ml4w now has support for, so you should add more images for fedora and opensuse and for example make the outputted image conditional using uname so on feodra, a feodra image is shown |
Network module in waybar: Now u can see the wifi SSID
Terminal: Revamp the fastfetch and ohmyposh config
Rofi: New look overall (took the shots with my phone camera, rofi used to close on hitting screenshot lol, its annoying)
Notification Daemon: Completely switched over to swaync with a dynamic theming notification center