Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme docker-compose file for MyBB 1.9 #8

Open
wants to merge 1 commit into
base: develop/1.9
Choose a base branch
from
Open

Update readme docker-compose file for MyBB 1.9 #8

wants to merge 1 commit into from

Conversation

KevinVR
Copy link

@KevinVR KevinVR commented Jun 5, 2021

  • Build from the Dockerfile instead of using the image for 1.9 since it is not yet published
  • Added some information regarding database connections

@KevinVR
Update readme docker-compose file for MyBB 1.9
149d1a8 
- Build from the Dockerfile instead of using the image for 1.9 since it is not yet published
- Added some information regarding database connections
euantorano
euantorano requested changes Jun 7, 2021
View reviewed changes
Copy link
Member

@euantorano euantorano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding the changes to the example compose/stack file. Addition of DB details seems useful to me.

README.md
@@ -36,7 +36,7 @@ Example `stack.yml` for `mybb`:
```yaml
services:
mybb:
image: mybb/mybb:latest
build: .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is supported for docker swarm/docker stack (only Compose). If that's the case, the title likely needs changing.

(of course, it's possible I've just not been keeping up to date and this is now supported...)

dav3yblaz3
dav3yblaz3 approved these changes Dec 26, 2024
View reviewed changes
Copy link

@dav3yblaz3 dav3yblaz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good can we try for test thanks team

@dav3yblaz3
Copy link

looks good for test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euantorano euantorano euantorano requested changes

@dav3yblaz3 dav3yblaz3 dav3yblaz3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinVR @dav3yblaz3 @euantorano