Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing a few typos #21

Open
wants to merge 1 commit into
base: add-2019-q2-review
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions june-2019/mybb-quarterly-review-q2-2019.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ At the current moment, the 1.9 branch is in line with MyBB 1.8.16. As we mention

Once the re-base is complete, there are still a couple of other tasks for 1.9 before we can release our first Alpha and Beta releases. Some of these issues include:

- [Implement a new email system](https://github.com/mybb/mybb/issues/2909). The current MyBB email system causes no end of support threads due to its limited support for slight variations in the way email servers speak the SMTP protocol. We're proposing that we adopt an existing well tested and support email sending library to manage the sending of emails. From a core point of view, this should be relatively simple since almost every email sent uses a single standard function (`my_mail()`).
- [Implement a new email system](https://github.com/mybb/mybb/issues/2909). The current MyBB email system causes no end of support threads due to its limited support for slight variations in the way email servers speak to the SMTP protocol. We're proposing that we adopt an existing well-tested and supported email sending library to manage the sending of emails. From a core point of view, this should be relatively simple since almost every email sent uses a single standard function (`my_mail()`).
euantorano marked this conversation as resolved.
Show resolved Hide resolved


We're proposing that we adopt the new [`symfony/mailer`](https://github.com/symfony/mailer) library which provides easy ways to send email via SMTP as well as various email APIs such as Postmark.
- [Review any missed templates fro the Twig conversion](https://github.com/mybb/mybb/issues/3684). During the re-base effort, we've noticed some lingering uses of the old template system within the core. These need to be rounded up and eliminated to ensure the template system usage throughout is consistent.
- [Update the ACP to allow editing of Twig template files](https://github.com/mybb/mybb/issues/3686). So far, the team have all been editing Twig template files directly via the Twig files. While this is a great way to work (who doesn't want to use their own editor of choice?), being able to eat templates easily within the ACP is a useful feature that needs updating to work with the new template system. There is some discussion about looking at the JavaScript code editor that we use when editing templates to see if there are any better options on the market. An often requested feature has been the ability to edit multiple templates within tabs at the same time, an enhancement which would be very handy when working with new templates.
- [Update the ACP to allow editing of Twig template files](https://github.com/mybb/mybb/issues/3686). So far, the team have all been editing Twig template files directly via the Twig files. While this is a great way to work (who doesn't want to use their own editor of choice?), being able to edit templates easily within the ACP is a useful feature that needs updating to work with the new template system. There is some discussion about looking at the JavaScript code editor that we use when editing templates to see if there are any better options on the market. An often requested feature has been the ability to edit multiple templates within tabs at the same time, an enhancement which would be very handy when working with new templates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm being dumb, but I can't see any difference here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- to eat templates
+ to edit templates


We will also be starting to update and introduce documentation for 1.9. If there are any documentation pages that you would like to see updated or improved, now would be a great time to bring them to our attention!

## Community Update

*... TODO ...*
*... TODO ...*