WIP/PROPOSAL - Redis publishing format #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ETetzlaff
force-pushed
the
et/redis-pub-format
branch
2 times, most recently
from
131f24d to
0adb0c1
Compare
…for language agnostic polling
ETetzlaff
force-pushed
the
et/redis-pub-format
branch
from
0adb0c1 to
ad022a6
Compare
ETetzlaff
changed the title
film42
reviewed
Nov 5, 2021
lib/active_publisher/message.rb
Outdated
| end | ||
|
|
||
| def to_json | ||
| self.to_h.to_json |
There was a problem hiding this comment.
We will probably want to wrap "payload" in base64 encoding to avoid parsing random bytes as a string in json (won't work).
|
We will need to bump toACTIVE_PUBLISHER_LIST.V2 or something to avoid breaking changes (reading from a queue with marshal'd data instead of json encoded data). I think we can ignore the "safe upgrade" path though. We can make the assumption that the queue is empty before we upgrade, but bumping the list key version assures this is true.
|
ETetzlaff
force-pushed
the
et/redis-pub-format
branch
2 times, most recently
from
41379b0 to
960e059
Compare
ETetzlaff
force-pushed
the
et/redis-pub-format
branch
from
960e059 to
4328256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts serialization from
MarshaltoJSONwhen publishing into Redis. This could theoretically allow for any language to poll Redis and publish into Rabbit or whatever sink as well.