Check rabbitmq connection status and reconnect when disconnected #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying client should be good about reconnecting, but we are seeing behavior where a runtime (in this case JRuby) is using a lot of mem and then fails to disconnect despite every other connection (thousands of others) working just fine. Perhaps it's safer to reconnect and let the publishers figure it out? Right now we see: ``` com.rabbitmq.client.AlreadyClosedException: connection is already closed due to connection error; cause: java.io.EOFException ``` This is called when the in-mem publisher tries to create a new channel (when a consumer thread is created). TODO: Will this potentially leak a connection? Should we explicitly disconnect the old connection?
|
LGTM |
|
I like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying client should be good about reconnecting, but we are
seeing behavior where a runtime (in this case JRuby) is using a lot of
mem and then fails to disconnect despite every other connection
(thousands of others) working just fine. Perhaps it's safer to reconnect
and let the publishers figure it out?
Right now we see:
This is called when the in-mem publisher tries to create a new channel
(when a consumer thread is created).
TODO: Will this potentially leak a connection? Should we explicitly
disconnect the old connection?