-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Yarn v3 (berry) #48
base: master
Are you sure you want to change the base?
Conversation
updated script to handle yarn berry
const packagedName = fs.readdirSync(dir).find(file => regex.test(file)) | ||
let packagedName = fs.readdirSync(dir).find(file => regex.test(file)) | ||
|
||
if(hasYarn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs, hasYarn
is a function.
Have you tested your code on yarn 1 or 2 with these changes?
let packagedName = fs.readdirSync(dir).find(file => regex.test(file)) | ||
|
||
if(hasYarn) { | ||
let yarnVersion = spawn.sync(['-v'], { cwd: dir, encoding: "utf8" }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a longhand version of the same flag, which will clearly signal the intent of the command? I know that yarn@1 has --version
in addition to -v
.
if(hasYarn) { | ||
let yarnVersion = spawn.sync(['-v'], { cwd: dir, encoding: "utf8" }); | ||
|
||
if(yarnVersion.stdout.replace('\n','').split('.')[0] >= 3) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non strict comparison with type coercion is a strongly discouraged because it is very error prone. Can we do it in a more safe manner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can use a semver parsing library if that works. I'll work on this over the next couple of days.
Add option to specify package
When using yarn berry the pack command always outputs
package.tgz
instead of using the package name in the filename. This patch fixes that issue.