Skip to content

Commit

Permalink
upgrade node version (mosaicml#2492)
Browse files Browse the repository at this point in the history
# What does this PR do?
Security vulnerability in `semver` seen due to node. This PR upgrades the node version to bump up semver from 7.5.1 to 7.5.2

# Tests
Action Run: https://github.com/mosaicml/composer/actions/runs/6017539089
Correct version of semver seen after upgrade: 
```
#14 [pytorch_stage  7/24] RUN npm list -g semver --depth=1
#14 2.223 /usr/lib
#14 2.223 `-- [email protected]
#14 2.223   `-- [email protected]
#14 2.223 
#14 DONE 2.4s
```
  • Loading branch information
j316chuck authored Aug 29, 2023
1 parent 276205b commit 252389f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ RUN add-apt-repository ppa:git-core/ppa && \
# Install NodeJS (for Pyright)
##############################
RUN \
curl -fsSL https://deb.nodesource.com/setup_18.x | bash - && \
curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && \
apt-get install -y --no-install-recommends nodejs && \
apt-get autoclean && \
apt-get clean && \
Expand Down

0 comments on commit 252389f

Please sign in to comment.