fix(non-italic-variants): remove italics from fontStyle only

mvllow · Apr 5, 2023 · adeb230 · adeb230
1 parent 3447cce
commit adeb230
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/source/commands/build.ts b/source/commands/build.ts
@@ -110,8 +110,8 @@ const parseVariant = (
 
 	if (options.includeNonItalicVariants) {
 		const removeItalics = JSON.stringify(parsedTheme).replace(
-			/\s?italic\s?/g,
-			'',
+			/(fontStyle":\s*?"[^.]*?)(italic)([^.]*?")/g,
+			'$1$3',
 		);
 		const parsedNonItalicTheme = {
 			...(JSON.parse(removeItalics) as Theme),

diff --git a/source/commands/init.ts b/source/commands/init.ts
@@ -25,6 +25,12 @@ export const init = async (source: string) => {
 \t\t\t\t"foreground": "$foreground",
 \t\t\t\t"fontStyle": "italic"
 \t\t\t}
+\t\t},
+\t\t{
+\t\t\t"scope": "markup.italic.markdown",
+\t\t\t"settings": {
+\t\t\t\t"fontStyle": "italic"
+\t\t\t}
 \t\t}
 \t]
 }`,

diff --git a/test/main.ts b/test/main.ts
@@ -64,6 +64,8 @@ test('includes non-italic variants', async (t) => {
 
 	t.notRegex(theme1, /fontStyle.*?italic/g);
 	t.notRegex(theme2, /fontStyle.*?italic/g);
+	// Ensure scope names are left unmodified
+	t.regex(theme2, /markup\.italic\.markdown/g);
 });
 
 test('removes empty values', async (t) => {