Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sixteen Hole Chromatic #8

Closed
wants to merge 1 commit into from
Closed

Conversation

FTWynn
Copy link

@FTWynn FTWynn commented Aug 24, 2020

Based off the Standard Chromatic set

Based off the Standard Chromatic set
@FTWynn
Copy link
Author

FTWynn commented Aug 25, 2020

Actually... This doesn't seem to work right just yet. I'll keep toying with it and resubmit.

@FTWynn FTWynn closed this Aug 25, 2020
@Ismael-VC
Copy link

@FTWynn I have created new PR #12 Could you check it out?

@Ismael-VC
Copy link

I think it didn't work as you have it, because you have to start on C3 not C4, so either way you select "16 holes..." plus "Low C" key or you have to put something like this:

        var C3 = 48;
        var C4 = 60;
        var chromatic16Tuning = 13;

        if (harpkey == C4 && harp.tuning == chromatic16Tuning) {
            harpkey = C3;
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants