Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kyber to final FIPS203 and rename to ML-KEM #362

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

mkannwischer
Copy link
Contributor

This integrates the changes made in the final FIPS203 standard.

Closes #353

See PQClean/PQClean#564.

Still need to re-run the benchmarks on Monday, but this shouldn't change much.

@mkannwischer mkannwischer requested a review from rpls October 14, 2024 02:23
@rpls
Copy link
Contributor

rpls commented Oct 14, 2024

Looks good to me! Btw. an idea for the future: have a checklist for new/changed schemes. E.g.:

  • Updated Benchmarks
  • Updated Skiplist entries
  • Testvectors pass

@mkannwischer mkannwischer merged commit 79a0ddf into master Oct 14, 2024
6 checks passed
@mkannwischer mkannwischer deleted the fips203 branch October 14, 2024 10:16
@mkannwischer
Copy link
Contributor Author

Looks good to me! Btw. an idea for the future: have a checklist for new/changed schemes. E.g.:

  • Updated Benchmarks
  • Updated Skiplist entries
  • Testvectors pass

Nice idea, I added a PR template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ML-KEM/Kyber to be compliant with FIPS203
2 participants