Kyber: Fixed secret-dependent branch in poly_fromsg (#345)

* Fixed secret-dependent branch in poly_fromsg

* update mupq

* update Kyber benchmarks

* add missing prototype

* extend skiplist

* add Falcon benchmarks

benchmarks.csv

@@ -8,15 +8,15 @@ bikel3 (10 executions),opt,248083316,248083286,248083345,16405238,16405236,16405
 hqc-128 (10 executions),clean,52705201,52705180,52705224,105650897,105650877,105650927,159569179,159569176,159569183
 hqc-192 (10 executions),clean,161458617,161458590,161458638,323146261,323146250,323146292,486156251,486156214,486156266
 hqc-256 (10 executions),clean,295934078,295934057,295934104,591853870,591853850,591853898,891163005,891162988,891163038
-kyber1024 (10 executions),clean,1540378,1537672,1549497,1707203,1704498,1716319,2019461,2016781,2028566
-kyber1024 (10 executions),m4fspeed,1007332,1004620,1027834,1025692,1023006,1046169,1088140,1085497,1108618
-kyber1024 (10 executions),m4fstack,1010439,1007447,1019916,1034164,1031168,1043640,1097375,1094378,1106850
-kyber512 (10 executions),clean,596231,595868,596646,696137,695809,696547,884186,883823,884599
-kyber512 (10 executions),m4fspeed,387168,386737,387669,386230,385800,386729,423509,423078,424010
-kyber512 (10 executions),m4fstack,386859,386551,387231,388111,387802,388486,425445,425136,425820
-kyber768 (10 executions),clean,990392,988002,998996,1134996,1132606,1143599,1384768,1382378,1393371
-kyber768 (10 executions),m4fspeed,631922,631406,632490,651769,651258,652364,700842,700331,701436
-kyber768 (10 executions),m4fstack,633057,632425,633410,656716,656088,657072,706247,705620,706604
+kyber1024 (10 executions),clean,1540394,1537580,1549267,1712150,1709337,1721019,2024408,2021583,2033304
+kyber1024 (10 executions),m4fspeed,1006341,1004590,1016692,1029398,1027642,1039752,1091847,1090091,1102201
+kyber1024 (10 executions),m4fstack,1009603,1007702,1019835,1038001,1036100,1048226,1101208,1099307,1111470
+kyber512 (10 executions),clean,597372,596106,607563,702227,700957,712416,890274,889008,900467
+kyber512 (10 executions),m4fspeed,387341,386762,387769,391098,390520,391527,428365,427786,428794
+kyber512 (10 executions),m4fstack,386853,386573,387221,392801,392521,393166,430140,429861,430504
+kyber768 (10 executions),clean,989247,987825,999577,1138807,1137381,1149131,1388568,1387146,1398896
+kyber768 (10 executions),m4fspeed,631912,631599,632459,656455,656155,656969,705524,705223,706037
+kyber768 (10 executions),m4fstack,634213,632786,644273,662556,661130,672615,712081,710655,722140
 Signature Schemes,,,,,,,,,,
 Scheme,Implementation,Key Generation [cycles] (mean),Key Generation [cycles] (min),Key Generation [cycles] (max),Sign [cycles] (mean),Sign [cycles] (min),Sign [cycles] (max),Verify [cycles] (mean),Verify [cycles] (min),Verify [cycles] (max)
 aimer-l1-param1 (10 executions),ref,392943,392938,392977,32386301,32386203,32386424,31111672,31111588,31111782
@@ -54,17 +54,21 @@ dilithium3 (1000 executions),m4fstack,3412759,3406659,3419247,23673016,6733971,1
 dilithium5 (1000 executions),clean,5341477,5286872,5395822,15710371,7953367,75940093,5609679,5609217,5610183
 dilithium5 (1000 executions),m4f,4275029,4210286,4329519,7977781,4882524,25936176,4185417,4184925,4185896
 dilithium5 (1000 executions),m4fstack,5816287,5474236,6115061,33452872,11170780,185259803,9912851,9845789,9981834
-falcon-1024 (10 executions),m4-ct,354880005,284902033,635131652,87741288,87506676,87922628,991320,982548,997219
-falcon-1024 (10 executions),opt-ct,555202324,284912829,1157528581,87710190,87606677,87841235,993584,983066,997523
-falcon-1024 (10 executions),opt-leaktime,438412062,334858742,625013074,80139483,79891200,80551967,994127,984891,997390
-falcon-1024-tree (10 executions),opt-ct,500950316,327706067,969046860,39207109,39013867,39449442,992787,982032,998080
-falcon-1024-tree (10 executions),opt-leaktime,372505822,284807343,551245131,42213136,41842229,42582424,995859,984960,998421
-falcon-512 (10 executions),m4-ct,161245486,110088298,279215300,40225282,40072879,40389913,478930,472982,485577
-falcon-512 (10 executions),opt-ct,151650543,116181731,228216352,40147309,40003575,40360540,480990,472795,485260
-falcon-512 (10 executions),opt-leaktime,159608965,111149933,301580807,37267337,36991076,37518518,478421,471680,484872
-falcon-512-tree (10 executions),m4-ct,167653515,121618919,272326714,18250061,18135371,18325579,479823,471774,485540
-falcon-512-tree (10 executions),opt-ct,184949574,121623805,270290280,18248036,18069599,18462666,484565,484059,485335
-falcon-512-tree (10 executions),opt-leaktime,156710258,106732109,326634247,20050613,19891001,20227947,482101,472948,485643
+falcon-1024 (10 executions),clean,602066436,377135260,1488065363,136241759,136017549,136556585,1678109,1677732,1678566
+falcon-1024 (10 executions),m4-ct,408725773,314885208,712370124,87706019,87549942,87839508,990541,984448,997160
+falcon-1024 (10 executions),opt-ct,448194494,301446952,784390745,87699336,87550679,87857833,992822,983184,998271
+falcon-1024 (10 executions),opt-leaktime,371539477,261831977,576613448,80134413,79844667,80338608,992815,982774,998600
+falcon-1024-tree (10 executions),opt-ct,469168139,341160847,733947155,39197559,39095597,39392055,995190,984826,998305
+falcon-1024-tree (10 executions),opt-leaktime,418213501,284879287,699555143,42181577,41844047,42456098,991791,983935,997742
+falcon-512 (10 executions),clean,229742458,134930383,358460785,62255726,62124149,62424751,834970,834402,835533
+falcon-512 (10 executions),m4-ct,146357328,106015844,250638532,40191597,40123901,40381630,482280,472137,485160
+falcon-512 (10 executions),opt-ct,168942163,106015882,258726842,40136012,40046972,40195851,481102,472809,485947
+falcon-512 (10 executions),opt-leaktime,130638983,94352160,240934147,37196341,36969717,37564986,476152,471514,484487
+falcon-512-tree (10 executions),m4-ct,187840863,121618909,531189026,18199972,18111179,18297541,479819,472890,485685
+falcon-512-tree (10 executions),opt-ct,179501018,121618960,347996956,18222471,18064774,18329860,479635,472057,484767
+falcon-512-tree (10 executions),opt-leaktime,203618838,106760540,425495750,20110699,19752157,20375122,480119,472263,485743
+falcon-padded-1024 (10 executions),clean,464867653,351942875,908060882,136157961,135988344,136430038,1677719,1677506,1677932
+falcon-padded-512 (10 executions),clean,241548154,164862595,348699388,62231774,62096573,62365088,834766,834480,834957
 haetae2 (100 executions),m4f,6743278,1555292,25393506,21993963,4721290,86765689,918459,918244,918668
 haetae2 (100 executions),ref,9363639,1716264,41895014,31631089,6247382,216853925,1104080,1103874,1104329
 haetae3 (100 executions),m4f,12925388,2752846,52240529,30891994,7467529,160522018,1760745,1760408,1761081
@@ -204,19 +208,21 @@ dilithium3,m4fstack,4408,6608,2704,,,,,,
 dilithium5,clean,97696,122724,92940,,,,,,
 dilithium5,m4f,97688,116076,92932,,,,,,
 dilithium5,m4fstack,4408,8136,2712,,,,,,
-falcon-1024,clean,34988,84604,8784,,,,,,
+falcon-1024,clean,35076,84604,8776,,,,,,
 falcon-1024,m4-ct,1156,2508,376,,,,,,
-falcon-1024,opt-ct,1156,2508,376,,,,,,
-falcon-1024,opt-leaktime,1212,2580,376,,,,,,
-falcon-1024-tree,opt-ct,1252,2772,376,,,,,,
-falcon-1024-tree,opt-leaktime,1212,2988,376,,,,,,
-falcon-512,clean,18092,43548,4688,,,,,,
-falcon-512,m4-ct,1156,2428,376,,,,,,
-falcon-512,opt-ct,1156,2428,376,,,,,,
-falcon-512,opt-leaktime,1156,2492,376,,,,,,
-falcon-512-tree,m4-ct,1212,2636,376,,,,,,
+falcon-1024,opt-ct,1204,2508,376,,,,,,
+falcon-1024,opt-leaktime,1252,2580,444,,,,,,
+falcon-1024-tree,opt-ct,1148,2884,376,,,,,,
+falcon-1024-tree,opt-leaktime,1196,2988,376,,,,,,
+falcon-512,clean,18180,43548,4680,,,,,,
+falcon-512,m4-ct,1148,2428,376,,,,,,
+falcon-512,opt-ct,1244,2428,376,,,,,,
+falcon-512,opt-leaktime,1148,2492,376,,,,,,
+falcon-512-tree,m4-ct,1172,2636,376,,,,,,
 falcon-512-tree,opt-ct,1156,2636,376,,,,,,
-falcon-512-tree,opt-leaktime,1212,2828,376,,,,,,
+falcon-512-tree,opt-leaktime,1196,2828,376,,,,,,
+falcon-padded-1024,clean,34988,84596,8776,,,,,,
+falcon-padded-512,clean,18092,43540,4680,,,,,,
 haetae2,m4f,19756,55568,23296,,,,,,
 haetae2,ref,26092,54444,29696,,,,,,
 haetae3,m4f,29596,83420,31784,,,,,,
@@ -311,15 +317,15 @@ bikel3,opt,0.0,6.3,0.2,,,,,,
 hqc-128,clean,0.4,0.8,0.5,,,,,,
 hqc-192,clean,0.3,0.5,0.3,,,,,,
 hqc-256,clean,0.2,0.4,0.3,,,,,,
-kyber1024,clean,50.0,45.8,38.7,,,,,,
-kyber1024,m4fspeed,76.0,75.8,71.5,,,,,,
-kyber1024,m4fstack,75.9,75.3,71.0,,,,,,
-kyber512,clean,49.8,41.4,32.6,,,,,,
-kyber512,m4fspeed,76.6,74.4,68.0,,,,,,
-kyber512,m4fstack,76.6,74.0,67.6,,,,,,
-kyber768,clean,48.4,43.3,35.5,,,,,,
-kyber768,m4fspeed,75.4,74.9,69.6,,,,,,
-kyber768,m4fstack,75.4,74.5,69.3,,,,,,
+kyber1024,clean,49.9,45.6,38.6,,,,,,
+kyber1024,m4fspeed,76.1,75.5,71.2,,,,,,
+kyber1024,m4fstack,75.8,74.9,70.6,,,,,,
+kyber512,clean,49.8,41.1,32.5,,,,,,
+kyber512,m4fspeed,76.5,73.5,67.1,,,,,,
+kyber512,m4fstack,76.5,73.1,66.8,,,,,,
+kyber768,clean,48.5,43.2,35.4,,,,,,
+kyber768,m4fspeed,75.4,74.4,69.2,,,,,,
+kyber768,m4fstack,75.3,73.8,68.7,,,,,,
 Signature Schemes,,,,,,,,,,
 Scheme,Implementation,Key Generation [%],Sign [%],Verify [%],,,,,,
 aimer-l1-param1,ref,72.0,47.2,46.7,,,,,,
@@ -357,19 +363,21 @@ dilithium3,m4fstack,77.1,54.6,41.0,,,,,,
 dilithium5,clean,67.0,35.7,61.1,,,,,,
 dilithium5,m4f,83.5,65.0,81.7,,,,,,
 dilithium5,m4fstack,76.1,54.5,42.6,,,,,,
-falcon-1024,clean,6.5,0.3,23.7,,,,,,
-falcon-1024,m4-ct,7.4,0.4,32.4,,,,,,
-falcon-1024,opt-ct,11.7,0.4,32.2,,,,,,
-falcon-1024,opt-leaktime,12.3,0.5,32.4,,,,,,
-falcon-1024-tree,opt-ct,5.2,0.9,32.3,,,,,,
-falcon-1024-tree,opt-leaktime,11.9,0.9,32.4,,,,,,
-falcon-512,clean,10.9,0.4,26.0,,,,,,
-falcon-512,m4-ct,15.3,0.5,34.3,,,,,,
-falcon-512,opt-ct,17.2,0.5,33.6,,,,,,
-falcon-512,opt-leaktime,16.0,0.5,33.8,,,,,,
-falcon-512-tree,m4-ct,18.4,1.1,33.9,,,,,,
-falcon-512-tree,opt-ct,14.5,1.1,33.9,,,,,,
-falcon-512-tree,opt-leaktime,18.7,1.0,33.9,,,,,,
+falcon-1024,clean,8.9,0.3,23.7,,,,,,
+falcon-1024,m4-ct,8.6,0.4,32.2,,,,,,
+falcon-1024,opt-ct,9.8,0.4,32.2,,,,,,
+falcon-1024,opt-leaktime,10.9,0.5,32.2,,,,,,
+falcon-1024-tree,opt-ct,9.2,0.9,32.3,,,,,,
+falcon-1024-tree,opt-leaktime,10.6,0.9,32.3,,,,,,
+falcon-512,clean,7.9,0.4,26.0,,,,,,
+falcon-512,m4-ct,13.7,0.5,33.9,,,,,,
+falcon-512,opt-ct,14.0,0.5,33.2,,,,,,
+falcon-512,opt-leaktime,17.3,0.5,33.6,,,,,,
+falcon-512-tree,m4-ct,12.6,1.1,33.7,,,,,,
+falcon-512-tree,opt-ct,14.6,1.1,34.2,,,,,,
+falcon-512-tree,opt-leaktime,20.5,1.0,34.3,,,,,,
+falcon-padded-1024,clean,7.3,0.3,23.7,,,,,,
+falcon-padded-512,clean,16.0,0.4,26.0,,,,,,
 haetae2,m4f,12.4,56.7,54.1,,,,,,
 haetae2,ref,10.6,42.4,45.1,,,,,,
 haetae3,m4f,14.6,56.6,57.1,,,,,,
@@ -463,15 +471,15 @@ bikel3,opt,43091,24,1,43116,,,,,
 hqc-128,clean,18628,0,0,18628,,,,,
 hqc-192,clean,21104,0,0,21104,,,,,
 hqc-256,clean,26260,0,0,26260,,,,,
-kyber1024,clean,6296,0,0,6296,,,,,
-kyber1024,m4fspeed,16912,0,0,16912,,,,,
-kyber1024,m4fstack,14120,0,0,14120,,,,,
-kyber512,clean,5164,0,0,5164,,,,,
-kyber512,m4fspeed,15824,0,0,15824,,,,,
-kyber512,m4fstack,13308,0,0,13308,,,,,
-kyber768,clean,5168,0,0,5168,,,,,
-kyber768,m4fspeed,15992,0,0,15992,,,,,
-kyber768,m4fstack,13316,0,0,13316,,,,,
+kyber1024,clean,6264,0,0,6264,,,,,
+kyber1024,m4fspeed,16884,0,0,16884,,,,,
+kyber1024,m4fstack,14092,0,0,14092,,,,,
+kyber512,clean,5132,0,0,5132,,,,,
+kyber512,m4fspeed,15796,0,0,15796,,,,,
+kyber512,m4fstack,13280,0,0,13280,,,,,
+kyber768,clean,5136,0,0,5136,,,,,
+kyber768,m4fspeed,15964,0,0,15964,,,,,
+kyber768,m4fstack,13288,0,0,13288,,,,,
 Signature Schemes,,,,,,,,,,
 Scheme,Implementation,.text [bytes],.data [bytes],.bss [bytes],Total [bytes],,,,,
 aimer-l1-param1,ref,19302,468,0,19770,,,,,
@@ -509,19 +517,21 @@ dilithium3,m4fstack,23448,0,0,23448,,,,,
 dilithium5,clean,7808,0,0,7808,,,,,
 dilithium5,m4f,18468,0,0,18468,,,,,
 dilithium5,m4fstack,23820,0,0,23820,,,,,
-falcon-1024,clean,82647,0,0,82647,,,,,
+falcon-1024,clean,82703,0,0,82703,,,,,
 falcon-1024,m4-ct,81825,0,79872,161697,,,,,
 falcon-1024,opt-ct,81825,0,79872,161697,,,,,
 falcon-1024,opt-leaktime,75429,0,79872,155301,,,,,
 falcon-1024-tree,opt-ct,81569,0,55296,136865,,,,,
 falcon-1024-tree,opt-leaktime,75173,0,55296,130469,,,,,
-falcon-512,clean,82611,0,0,82611,,,,,
+falcon-512,clean,82663,0,0,82663,,,,,
 falcon-512,m4-ct,81825,0,39936,121761,,,,,
 falcon-512,opt-ct,81825,0,39936,121761,,,,,
 falcon-512,opt-leaktime,75429,0,39936,115365,,,,,
 falcon-512-tree,m4-ct,81569,0,27648,109217,,,,,
 falcon-512-tree,opt-ct,81569,0,27648,109217,,,,,
 falcon-512-tree,opt-leaktime,75173,0,27648,102821,,,,,
+falcon-padded-1024,clean,82643,0,0,82643,,,,,
+falcon-padded-512,clean,82599,0,0,82599,,,,,
 haetae2,m4f,35708,0,0,35708,,,,,
 haetae2,ref,25568,0,0,25568,,,,,
 haetae3,m4f,35936,0,0,35936,,,,,