Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
assertRaises
and fixed broken asserts (checking the wrong strings but doing it inside the raises block, leading to the test passing when it should've failed)S2
Notable uncovered areas
In addition to numerous exceptions and minor branches that are not covered (i.e. raising an exception if a file that should always be present is missing), the following areas have functional code that is currently untested but could be:
calc
attribute for ASE atoms, needs further analysisDFTB tests don't run, as
_RUN_DFTB
is hardcodedFalse
. Haven't looked into this too much yet. Don't know if it's more feasible to try and install DFTB+ on the GHA runners or try and increase coverage by unit testing the following (currently uncovered) functions:The following files have no coverage, and are not called anywhere else in the codebase. Could write tests for them, but is it worth it for code that is never used? May have value as library functions but it's not obvious to me if they do.
Following discussion with @leandro-liborio will keep the following:
And remove the following:
#48