Feature interpreter refactor #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flbulgarelli
force-pushed
the
feature-interpreter-improvements
branch
from
57ce563
to
dfd48d7
Compare
flbulgarelli
force-pushed
the
feature-interpreter-improvements
branch
from
dfd48d7
to
e631d04
Compare
flbulgarelli
changed the title
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are just minor refactors to the interpreter:
Internalsmodule has been extracted, with the internal data structures used by the interperetertypeErrorsand primitive operator wrappers have being slightly reifiyedAlso the python ignored tests were already passing.
Some notes:
Internalsmodule contains theExecutionContextandValuedefinitions which are currently core to the interpreter and exposed to any consumer of it. I am planning to hide them in the future with the introduction of aReplmodule that complements theRunnermodule.Also, I want to make primitives to be easy to implement since I am planning to introduce more of them. See #286