Use latest wallet package #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .yml file for label `ignore-for-release-notes`
Fixed sdk-py-wallet version
| message = ArbitraryMessage(bytes.fromhex(account.address.hex())) | ||
|
|
||
| signed_message = validator_signer.sign(message).hex() | ||
| signed_message = validator_signer.sign(account.address.pubkey).hex() |
There was a problem hiding this comment.
👍 here we do not use MessageV1, correct.
pyproject.toml
Outdated
| @@ -27,7 +28,7 @@ dependencies = [ | |||
| "requests-cache", | |||
| "rich==13.3.4", | |||
| "multiversx-sdk-network-providers>=0.11.0", | |||
| "multiversx-sdk-wallet>=0.7.0", | |||
| "multiversx-sdk-wallet>=0.8.0", | |||
There was a problem hiding this comment.
Here, we should protect against breaking changes, and add upper bounds, as well. Perhaps for all our libraries?
In requirements.txt, as well.
There was a problem hiding this comment.
Done for our libraries
requirements.txt
Outdated
| multiversx-sdk-wallet>=0.8.0 | ||
| multiversx-sdk-core>=0.6.0,<0.7.0 | ||
| multiversx-sdk-network-providers>=0.11.0,<0.12.0 | ||
| multiversx-sdk-wallet>=0.8.0,<0.9.9 |
andreibancioiu
approved these changes
Nov 1, 2023
ssd04
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated
sdk-py-wallet v0.8.0into mxpy.