Redlock service #182
Merged
Redlock service #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmatei
requested changes
Nov 14, 2023
| } | ||
|
|
||
| private async lockOnce(key: string, keyExpiration: number): Promise<boolean> { | ||
| const result = await this.redis.setnx(key, '1'); |
There was a problem hiding this comment.
SETNX is deprecated. You can use SET with the NX option
| private async lockOnce(key: string, keyExpiration: number): Promise<boolean> { | ||
| const result = await this.redis.setnx(key, '1'); | ||
| if (result === 1) { | ||
| await this.redis.pexpire(key, keyExpiration); |
There was a problem hiding this comment.
if you use SET, you can provide an expiration time and there is no need to make another call to redis
gabrielmatei
approved these changes
Nov 14, 2023
tanghel
added a commit
that referenced
this pull request
Nov 14, 2023
* redlock basic functionality * renamed metric correctly * set acquired duration also when not timing out * added redlock folder in index * extend ttl concept, improved logging * log level, other refactorings * use single set function with expiry integrated
tanghel
added a commit
that referenced
this pull request
Nov 20, 2023
* redlock basic functionality * renamed metric correctly * set acquired duration also when not timing out * added redlock folder in index * extend ttl concept, improved logging * log level, other refactorings * use single set function with expiry integrated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.