Fix redlock release key method (#204)

* Fix release method on redlock service * Upgrade packages
multiversx · Jan 30, 2024 · 3045ac7 · 3045ac7
1 parent 47edf11
commit 3045ac7
Show file tree

Hide file tree

Showing 11 changed files with 30 additions and 29 deletions.
diff --git a/lerna.json b/lerna.json
@@ -1,9 +1,9 @@
 {
   "$schema": "node_modules/lerna/schemas/lerna-schema.json",
   "useWorkspaces": true,
-  "version": "3.1.3",
+  "version": "3.1.4",
   "packages": [
     "packages/*"
   ],
   "npmClient": "npm"
-}
+}
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/auth/package.json b/packages/auth/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@multiversx/sdk-nestjs-auth",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Multiversx SDK Nestjs auth package",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -46,4 +46,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/cache/package.json b/packages/cache/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@multiversx/sdk-nestjs-cache",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Multiversx SDK Nestjs cache package",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -49,4 +49,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/cache/src/redlock/redlock.service.ts b/packages/cache/src/redlock/redlock.service.ts
@@ -17,8 +17,9 @@ export class RedlockService {
     private readonly metricsService: MetricsService,
   ) { }
 
-  async release(key: string): Promise<void> {
-    const promise = async (redis: Redis) => await redis.del(key);
+  async release(type: string, key: string): Promise<void> {
+    const lockKey = `${type}:${key}`;
+    const promise = async (redis: Redis) => await redis.del(lockKey);
     await Promise.allSettled(this.redisArray.map(promise));
   }
 
@@ -76,7 +77,7 @@ export class RedlockService {
         return lockResult;
       }
 
-      const releasePromise = async (redis: Redis) => await redis.del(key);
+      const releasePromise = async (redis: Redis) => await redis.del(lockKey);
       await Promise.allSettled(successInstances.map(releasePromise));
 
       await this.sleep(config.retryInterval);
@@ -127,7 +128,7 @@ export class RedlockService {
         clearTimeout(extensionId);
       }
 
-      this.release(lockKey).catch(error => {
+      this.release(type, key).catch(error => {
         this.logError(`Failed to release lock for resource '${lockKey}': ${error.message}`);
       });
 

diff --git a/packages/common/package.json b/packages/common/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@multiversx/sdk-nestjs-common",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Multiversx SDK Nestjs common package",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

diff --git a/packages/elastic/package.json b/packages/elastic/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@multiversx/sdk-nestjs-elastic",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Multiversx SDK Nestjs elastic package",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -37,4 +37,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/http/package.json b/packages/http/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@multiversx/sdk-nestjs-http",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Multiversx SDK Nestjs http package",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -46,4 +46,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/monitoring/package.json b/packages/monitoring/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@multiversx/sdk-nestjs-monitoring",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Multiversx SDK Nestjs monitoring package",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -41,4 +41,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/rabbitmq/package.json b/packages/rabbitmq/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@multiversx/sdk-nestjs-rabbitmq",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Multiversx SDK Nestjs rabbitmq client package",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -43,4 +43,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}
diff --git a/packages/redis/package.json b/packages/redis/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@multiversx/sdk-nestjs-redis",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Multiversx SDK Nestjs redis client package",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -40,4 +40,4 @@
   "publishConfig": {
     "access": "public"
   }
-}
+}